Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prepare mainnet runtime for registration #238

Merged
merged 8 commits into from
Aug 29, 2024
Merged

feat: prepare mainnet runtime for registration #238

merged 8 commits into from
Aug 29, 2024

Conversation

al3mart
Copy link
Collaborator

@al3mart al3mart commented Aug 27, 2024 •
edited by evilrobot-01
Loading

Adds a new runtime crate pop-runtime with the following changes in comparison to pop-runtime-testnet:

  • Barrier: allows for version subscriptions and removed unpaid execution.
pub type Barrier = TrailingSetTopicAsId<(
	TakeWeightCredit,
	AllowKnownQueryResponses<PolkadotXcm>,
	WithComputedOrigin<
		(AllowTopLevelPaidExecutionFrom<Everything>, AllowSubscriptionsFrom<Everything>),
		UniversalLocation,
		ConstU32<8>,
	>,
)>;
  • pallet_collator_selection:

Sets the desired number of candidates to 0 and the maximum number of candidates to 0 too. Effectively allowing only invulnerable collators.

Relevant relay chain specific params.

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 27.52137% with 424 lines in your changes missing coverage. Please review.

Project coverage is 11.21%. Comparing base (71d81b9) to head (8632306).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
runtime/mainnet/src/lib.rs 23.95% 273 Missing ⚠️
node/src/chain_spec.rs 27.77% 88 Missing and 3 partials ⚠️
node/src/command.rs 0.00% 27 Missing ⚠️
runtime/mainnet/src/config/proxy.rs 0.00% 15 Missing ⚠️
runtime/mainnet/src/config/xcm.rs 0.00% 6 Missing ⚠️
runtime/mainnet/src/weights/paritydb_weights.rs 73.33% 4 Missing ⚠️
runtime/mainnet/src/weights/rocksdb_weights.rs 73.33% 4 Missing ⚠️
runtime/mainnet/src/weights/block_weights.rs 81.81% 2 Missing ⚠️
runtime/mainnet/src/weights/extrinsic_weights.rs 81.81% 2 Missing ⚠️ 
@@            Coverage Diff            @@
##            main     #238      +/-   ##
=========================================
+ Coverage   6.40%   11.21%   +4.80%     
=========================================
  Files         27       34       +7     
  Lines       1997     2577     +580     
  Branches    1997     2577     +580     
=========================================
+ Hits         128      289     +161     
- Misses      1869     2285     +416     
- Partials       0        3       +3
Files with missing lines Coverage Δ
runtime/common/src/lib.rs 0.00% <ø> (ø)
runtime/testnet/src/lib.rs 3.89% <ø> (ø)
runtime/mainnet/src/weights/block_weights.rs 81.81% <81.81%> (ø)
runtime/mainnet/src/weights/extrinsic_weights.rs 81.81% <81.81%> (ø)
runtime/mainnet/src/weights/paritydb_weights.rs 73.33% <73.33%> (ø)
runtime/mainnet/src/weights/rocksdb_weights.rs 73.33% <73.33%> (ø)
runtime/mainnet/src/config/xcm.rs 0.00% <0.00%> (ø)
runtime/mainnet/src/config/proxy.rs 0.00% <0.00%> (ø)
node/src/command.rs 0.00% <0.00%> (ø)
node/src/chain_spec.rs 11.29% <27.77%> (+11.29%) ⬆️
... and 1 more

peterwht and others added 2 commits August 28, 2024 17:27
@peterwht peterwht marked this pull request as ready for review August 29, 2024 05:52
@evilrobot-01 evilrobot-01 changed the title chore: prepare runtime for registration feat: prepare mainnet runtime for registration Aug 29, 2024
evilrobot-01
evilrobot-01 reviewed Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various observations. See other PR to this one for a variety of fixes and improvements.

Note that the xcm and proxy config have not yet been reviewed.

node/src/chain_spec.rs Show resolved Hide resolved
runtime/mainnet/src/weights/block_weights.rs Show resolved Hide resolved
node/src/chain_spec.rs Show resolved Hide resolved
runtime/mainnet/src/lib.rs Outdated Show resolved Hide resolved
runtime/mainnet/src/lib.rs Show resolved Hide resolved
runtime/mainnet/src/lib.rs Outdated Show resolved Hide resolved
runtime/mainnet/src/lib.rs Outdated Show resolved Hide resolved
runtime/mainnet/src/lib.rs Show resolved Hide resolved
runtime/mainnet/src/lib.rs Show resolved Hide resolved
runtime/mainnet/src/lib.rs Show resolved Hide resolved
@evilrobot-01 evilrobot-01 mentioned this pull request Aug 29, 2024
Merged
evilrobot-01
evilrobot-01 requested changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various XCM things which need resolving.

runtime/mainnet/src/config/xcm.rs Outdated Show resolved Hide resolved
runtime/mainnet/src/config/xcm.rs Outdated Show resolved Hide resolved
runtime/mainnet/src/config/xcm.rs Outdated Show resolved Hide resolved
runtime/mainnet/src/config/xcm.rs Outdated Show resolved Hide resolved
runtime/mainnet/src/config/xcm.rs Outdated Show resolved Hide resolved
runtime/mainnet/src/config/xcm.rs Show resolved Hide resolved
runtime/mainnet/src/config/xcm.rs Show resolved Hide resolved
runtime/mainnet/src/config/xcm.rs Outdated Show resolved Hide resolved
evilrobot-01
evilrobot-01 requested changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one final change.

runtime/mainnet/src/lib.rs Outdated Show resolved Hide resolved
@peterwht peterwht merged commit bae5887 into main Aug 29, 2024
8 checks passed
@peterwht peterwht deleted the al3mart/chore-registration branch August 29, 2024 22:23
chungquantin pushed a commit that referenced this pull request Sep 6, 2024
@al3mart @peterwht
@evilrobot-01 @chungquantin
feat: prepare mainnet runtime for registration (#238)
f5577bf 
Co-authored-by: Peter White <petras9789@gmail.com>
Co-authored-by: Frank Bell <60948618+evilrobot-01@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwht peterwht peterwht approved these changes

@evilrobot-01 evilrobot-01 evilrobot-01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@al3mart @codecov-commenter @peterwht @evilrobot-01